Re: [B.A.T.M.A.N.] [PATCH v2 3/4] batman-adv: Introduce packet type independent TVLV handler API

@@ -1842,8 +1844,12 @@ static int batadv_iv_ogm_receive(struct sk_buff *skb,

            packet_pos = skb->data + ogm_offset;
            ogm_packet = (struct batadv_ogm_packet *)packet_pos;

•           skb_set_network_header(skb, ogm_offset);
    }
  
  

•   skb_reset_network_header(skb);
  

•   kfree_skb(skb);
    return NET_RX_SUCCESS;
  

}

[...] On Donnerstag, 6. Oktober 2016 08:41:40 CET Linus Lüssing wrote:

What do you think about wrapping the WARN_ON, while loop and skb_reset_network_header() into a new function with a functional, non-modifying touch regarding the input skb?

Or do you think I should just remove the skb_reset_network_header() here?

Hm, my point was not actually about the loop or the skb_set_network_header or the WARN_ON. I only don't know why a skb_reset_network_header would be necessary before a kfree_skb/consume_skb.

It also doesn't seem to be used in a later patch.

Kind regards, Sven