On Monday 09 May 2016 00:33:24 Antonio Quartulli wrote:
On Fri, May 06, 2016 at 09:53:26AM +0200, Sven Eckelmann wrote:
So you either have to add it to kernel-doc or do it differently.
Thanks for checking this. I will split the structure in real substructures with their own definition and document the fields there.
About the result from IWUY: any easy way to run it locally ? I tried to run it by specifying the IWYU path via CC=, but I get way more noisy result that what you reported in your previous email. I'd like to learn this so that I can easily understand which patch requires which include.
The actual script can be found in build_test.git [1]. But you can also download the repo, prepare the headers with generate_linux_headers.sh
LINUX_REPOSITORY=/home/sven/tmp/linux-next ./generate_linux_headers.sh
and then mount it
mkdir linux-build sudo mount -o loop linux-build.img linux-build
Now you can for example run the build tests and receive the mail:
REMOTE=/home/sven/tmp/qemu-batman/batman-adv TO=sven ./checkstuff.sh
Or you can extract the relevant part of the script (see attachment - file paths have to be adjusted; build_test.git with prepared headers is still required) and run it manually. Please make sure that you've committed your changed before running it because it will remove your local changes.
sh ~/tmp/testheaders.sh
If you wonder why a header was added then you should have a look at the "test" file which includes the "noisy" part which you've mentioned. You should at least use iwyu 3.5
On top of that, the results you posted says that I should include <linux/stddef.h> in bat_v.c, but it already included in that file. no?
Marek added it recently [2].
Kind regards, Sven
[1] https://git.open-mesh.org/build_test.git [2] https://git.open-mesh.org/batman-adv.git/commit/9685688ae7dd85804aec2f6ce760...