Re: [B.A.T.M.A.N.] [PATCH 07/12] batman-adv: Use packet lists for unicast packet sending

On Wednesday 02 March 2011 18:18:36 Linus Lüssing wrote:

•   entry = kmalloc(sizeof(struct packet_list_entry), GFP_ATOMIC);
  

•   if (!entry) {
  

•           kfree_skb(skb);
  

•           return;
  

•   }
  

•   entry->skb = skb;
  

•   entry->neigh_node = router;
  

•   hlist_add_head(&entry->list, packet_list);
  

In the past weeks we worked very hard to reduce the batman-adv overhead to a bare minimum (see the hash restructuring patches and the orig_hash spinlock removal) and now you want to add a malloc() for each forwarded packet ?? Can't we find a less bloated way to achieve the same thing ?

Regards, Marek