Re: [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: Remove unnecessary hardif_list_lock

On Tuesday 03 May 2011 11:51:38 Linus Lüssing wrote:

hardif_list_lock is unneccessary because we already ensure that no multiple admin operations can take place through rtnl_lock. hardif_list_lock only adds additional overhead and complexity.

Critical functions now check whether they are called with rtnl_lock using ASSERT_RTNL.

It indirectly fixes the problem that orig_hash_del_if() expects that only one interface is deleted from hardif_list at a time, but hardif_remove_interfaces() removes all at once and then calls orig_hash_del_if().

Applied in revision 7e95055.

Thanks, Marek