Re: [B.A.T.M.A.N.] [PATCH] batman-adv: a delayed_work has to be initialised once

On Tue, Dec 25, 2012 at 04:27:37 +0800, Marek Lindner wrote:

On Saturday, December 15, 2012 21:10:56 Antonio Quartulli wrote:

...

• batadv_start_purge_timer(bat_priv);

• INIT_DELAYED_WORK(&bat_priv->orig_work, batadv_purge_orig);
• queue_delayed_work(batadv_event_workqueue,

• 	   &bat_priv->orig_work, msecs_to_jiffies(1000));
  

• return 0;

err: @@ -396,7 +392,8 @@ static void batadv_purge_orig(struct work_struct *work) delayed_work = container_of(work, struct delayed_work, work); bat_priv = container_of(delayed_work, struct batadv_priv, orig_work); _batadv_purge_orig(bat_priv);

• batadv_start_purge_timer(bat_priv);

• queue_delayed_work(batadv_event_workqueue,

• 	   &bat_priv->orig_work, msecs_to_jiffies(1000));
  

}

If the same numeric value is used multiple times we should have a define.

Correct. I'll fix and resend.

Thanks a lot!

Cheers,