On Thu, Sep 16, 2010 at 12:30:35AM +0200, Sven Eckelmann wrote:
Hi Sven
...
The generated code is often incorrectly indented and right now contains comments that clarify for each added line why a specific variant was chosen. In the version that gets submitted upstream, the comments will be gone and I will manually fix the indentation, because there does not seem to be a way to do that using coccinelle.
...
diff --git a/batman-adv/bat_debugfs.c b/batman-adv/bat_debugfs.c index c73ce4a..0b35616 100644 --- a/batman-adv/bat_debugfs.c +++ b/batman-adv/bat_debugfs.c @@ -177,6 +177,7 @@ static const struct file_operations log_fops = { .release = log_release, .read = log_read, .poll = log_poll,
- .llseek = noop_llseek,/* read uses no f_pos */
};
Would it not be better to wait for the final version which has the indentation fixed and probably no comment? If you commit this version now, won't you get a conflict later?
Andrew