Re: [B.A.T.M.A.N.] [PATCHv2] batman-adv: postpone sysfs removal when unregistering

On Friday, January 11, 2013 01:09:21 Simon Wunderlich wrote:

+static void batadv_hardif_remove_interface_finish(struct work_struct *work) +{

• struct batadv_hard_iface *hard_iface;
• hard_iface = container_of(work, struct batadv_hard_iface,

• 		  cleanup_work);
  

• batadv_sysfs_del_hardif(&hard_iface->hardif_obj);
• batadv_hardif_free_ref(hard_iface);

+}

Kernel doc ?

+static void batadv_softif_destroy_finish(struct work_struct *work) +{

• struct batadv_priv *bat_priv;
• struct net_device *soft_iface;
• bat_priv = container_of(work, struct batadv_priv,

• 		cleanup_work);
  

• soft_iface = bat_priv->soft_iface;
• batadv_debugfs_del_meshif(soft_iface);
• batadv_sysfs_del_meshif(soft_iface);
• rtnl_lock();
• unregister_netdevice(soft_iface);
• rtnl_unlock();

+}

Kernel doc ?

The rest looks good. :)

Cheers, Marek