On Tuesday 22 October 2013 23:26:05 Linus Lüssing wrote:
With the current TVLV approach it is still going to be difficult to introduce new features / changes to batman-adv broadcast / coded / fragment / ... packets as the current approach only provides TVLVs for OGMs and unicast packets.
What kind of features are missing ? Can we please stay specific and not drift into the "meta" future where everything and anything could be added ? What is the feature or the features we are talking about ?
How difficult, I'm not quite sure. Initially I thought compat bumps would be needed for new broadcast features for instance, but now I realized, that this is not the case, because bcast features could be signalized via OGM TVLVs and like with the mcast patches, could be enabled only if all nodes have that bcast-feature OGM TVLV.
Currently, I could not come up with a bcast feature we would want to add that requires a compat bump. Please name it/them and state why a compat bump would be needed. This is where the discussion can start.
For the disadvantages of moving 'TVLVs down to the common header', I'm actually having trouble getting them. Maybe others could list them again and I try to explain which of these I'm having trouble understanding and why?
Again, let's start with an advantage of adding TVLVs using a practical example. We don't want to implement TVLVs for the sake of implementing TVLVs.
Cheers, Marek