Hey Antonio,
Thanks, that solves the problem on my ancient kernel! :)
I don't see a problem with -EEXIST (at least there is no error whatsoever), so I think we can leave it at that.
Tested-by: Simon Wunderlich simon.wunderlich@s2003.tu-chemnitz.de
Just one thing ...
On Thu, Aug 15, 2013 at 11:05:55PM +0200, Antonio Quartulli wrote:
From: Antonio Quartulli antonio@open-mesh.com
Before creating a new softif_vlan it is better to check if that does already exist. If so batman-adv should refuse to create a new structure otherwise this would lead to an inconsistent state.
Normally this is not a problem because the operating system will prevent from creating the same vlan twice, but some ancient kernels exhibited an improper behaviour that led to a bug.
You might want to skip that when sending upstream? They might not care about older kernels. Duno. :)
Thanks! Simon