On Thursday, October 18, 2012 02:48:39 Antonio Quartulli wrote:
Hm, no, I do not have a specific scenario in mind. I only accidentally noticed such an FF:FF:FF:FF:FF:FF mac address in our vis graph here when I made a typo with the tool 'mausezahn'.
I don't know of any RFC or so which would generally forbid using a multicast source MAC for every ether type (although for sane IPv4/v6 stacks I haven't seen something like this before either and yes, I bet it's not allowed there).
The Linux bridge I had on top of bat0 was happily forwarding such frames into batman-adv. So I thought doing it like the bridge code - forwarding but with no learning - might be the right way?
I think you are right. We should not care about the payload logic. If that is not allowed for the upper layer, then that layer will drop the packet once received.
So we should keep forwarding such packets and yes, we should prevent learning from them. Therefore:
Acked-by: Antonio Quartulli ordex@autistici.org
Applied in revision 9868989.
Thanks, Marek