On Friday 03 June 2016 00:00:44 Ben Hutchings wrote:
Commit a33d970d0b54 "batman-adv: Fix reference counting of vlan object for tt_local_entry") makes each batadv_tt_local_entry hold a single reference to a batadv_softif_vlan. In case a new entry cannot be added to the hash table, the error path puts the reference, but the reference will also now be dropped by batadv_tt_local_entry_release().
Fixes: a33d970d0b54 ("batman-adv: Fix reference counting of vlan object ...") Cc: Sven Eckelmann sven@narfation.org Signed-off-by: Ben Hutchings ben@decadent.org.uk
This is untested; I just spotted this apparent oversight while trying to backport the previous fix.
Yes, you are completely right. I've missed this line in the error handling path for hash_add in batadv_tt_local_add
Acked-by: Sven Eckelmann sven@narfation.org
Kind regards, Sven