Re: [B.A.T.M.A.N.] FWD: batman: potential null dereference

On Monday 08 March 2010 23:12:44 Andrew Lunn wrote:

Does somebody have time to look at this?

As far as I understand the question is: What happens if !orig_node->router && !neigh_node go into update_route() ?

Fairly easy to answer: Only update_routes() (note the "s") calls update_route() which checks for this case:

if (orig_node->router != neigh_node) update_route()

Not very obvious though ...

Regards, Marek

PS: Can we somehow better communicate that we have a mailing list for these kind of questions ?