Re: [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: Remove unused skb_reset_mac_header()

On Freitag, 22. Juli 2016 13:38:01 CEST Linus Lüssing wrote:

During broadcast queueing, the skb_reset_mac_header() sets the skb to a place invalid for a MAC header, pointing right into the batman-adv broadcast packet. Luckily, no one seems to actually use eth_hdr(skb) afterwards until batadv_send_skb_packet() resets the header to a valid position again.

Therefore removing this unnecessary, weird skb_reset_mac_header() call.

Signed-off-by: Linus Lüssing linus.luessing@c0d3.blue

Reviewed-by: Sven Eckelmann sven@narfation.org

Kind regards, Sven