On 03/08/2013 09:06 PM, Marek Lindner wrote:
On Saturday, March 09, 2013 03:42:34 Matthias Schiffer wrote:
In general, I like the idea but the approach isn't the best. Can't we automate these settings instead of adding hundreds of little knobs nobody will understand ? Why not detecting wifi interfaces as such and configure the broadcast value accordingly ? The same goes for ethernet / vpns ?
While is makes sense to find some sensible defaults for such values, in my opinion everything should be as configurable as possible. I don't think it would be a problem to have some dozens knobs more if a normal user almost never has to touch them. On the other hand, for testing, debugging and development purposes, it can save a lot of time not having to recompile the kernel for such changes all the time.
Knobs only used for debugging and development should never go into sysfs. User space APIs are created for life time. Once it is there and we submit it to the kernel the API has to stay and has to be supported forever.
You have a point there... While I still think making the broadcast count adjustable makes sense, I'd also be happy to get a patch accepted that just sets the broadcast count depending on the interface type.
My current plan is:
* WLAN devices: 3 broadcasts * Everything else: 1 broadcast
Any additional types that should be considered?
Also, for VPN connections, automatic detection of the link type isn't generally possible, as we'd have to know which medium the VPN is going over...
You are running batman-adv over VPN links on top of wifi interfaces ?
Not yet, but extrapolating from the setups I've already done, it's probably just a matter of time until I am ;)
Matthias
Cheers, Marek