Re: [B.A.T.M.A.N.] [PATCHv2] batman-adv: protect tt request from double deletion

On Saturday, June 20, 2015 10:26:31 Sven Eckelmann wrote:

On Friday 19 June 2015 21:50:27 Marek Lindner wrote:

...

The list_del() call was changed to hlist_del_init() to allow take advantage of the hlist_unhashed() check prior to deletion in batadv_tt_req_node_new().

Signed-off-by: Marek Lindner mareklindner@neomailbox.ch

v2: removed redundant hlist_unhashed() check & reword commit message

list_del_init would also work. It is not necessary to switch to hlists for this feature. It is not possible with RCU but this is not used here.

I am aware of that fact. Still, I'd like to convert the list to hlist. If you prefer I can do this in 2 steps (first changing to list_del_init() and then changing everything to hlist).

Cheers, Marek