Re: [B.A.T.M.A.N.] [PATCHv2] batman-adv: use eth_hdr() instead of skb->data in interface_tx path

Hi Linus!

On 16/01/14 01:39, Linus Lüssing wrote:

• if ((struct ethhdr *)skb->data != eth_hdr(skb)) {

• pr_warn("Upper device did not set the ethernet header pointer correctly - adjusting\n");
  

• skb_reset_mac_header(skb);
  

• }

I think that if we really want to properly set the mac_header we should just do it and forget about the if and about the warning.

It's a really "stupid" operation and in the end we have many spots in the kernel where the pointers are just set without adding too much overhead like messages or other things...

Cheers,