Re: [B.A.T.M.A.N.] [PATCH v2 9/9] batman-adv: Use kref_get for _batadv_update_route

On Saturday, March 05, 2016 19:05:24 Sven Eckelmann wrote:

_batadv_update_route requires that the caller already has a valid reference for neigh_node. It is therefore not possible that it has an reference counter of 0 and was still given to this function

The kref_get function instead WARNs (with debug information) when the reference counter would still be 0. This makes a bug in batman-adv better visible because kref_get_unless_zero would have ignored this problem.

Signed-off-by: Sven Eckelmann sven@narfation.org

This patch requires https://patchwork.open-mesh.org/patch/15888/

v2:

•  Remove one of the empty lines around the removed block
  
  

net/batman-adv/routing.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)

Applied in revision 4390308.

Thanks, Marek