14 May
2021
14 May
'21
8:28 a.m.
On Tuesday, 27 April 2021 20:45:27 CEST Linus Lüssing wrote:
- The skb is not consumed, so the caller should make sure that the
- skb is freed.
- This call clones the given skb, hence the caller needs to take into
- account that the data segment of the original skb might not be
- modifiable anymore.
But none of your callers is now taking care of it because you've removed all skb_copy's. All you do is to clone the control data and give it to the underlying layers. And they may write freely to the data. Thus breaking parallel (and under some circumstances sequential) running code which operates on the skbs.
The review was stopped after noticing this problem.
Kind regards, Sven