On Dienstag, 19. Juli 2016 22:44:08 CEST Sven Eckelmann wrote:
The list-batman implementation of linked lists has an interface which tries to resample the linux double linked list implementation but in reality is incompatible. This resulted in code which moves most of the pointer arithmetic back to the actual code. This is rather unfortunate because this abstraction should reduce the pointer arithmetic and not increase it.
Also the incompatibilities between the list implementation used in batman-adv and the one used by batctl made coding features in both components error prone because each component required a slightly different implementation for the same list manipulation.
Signed-off-by: Sven Eckelmann sven@narfation.org
Makefile | 1 - bisect_iv.c | 40 ++- bisect_iv.h | 10 +- list-batman.c | 123 --------- list-batman.h | 120 --------- list.h | 834 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ tcpdump.c | 7 +- tcpdump.h | 2 +- 8 files changed, 860 insertions(+), 277 deletions(-) delete mode 100644 list-batman.c delete mode 100644 list-batman.h create mode 100644 list.h
Applied in 315b3b0fac147b9d8dc8f83a6409fde91eca683a [1].
Kind regards, Sven
[1] https://git.open-mesh.org/batctl.git/commit/315b3b0fac147b9d8dc8f83a6409fde9...