Simon Wunderlich wrote:
I've also followed your other comments (hopefully correctly), so thank you very much for the review.
[...]
This is an experimental patch and targeted for upcoming experiments at Wireless Battle Mesh v3 in Bracciano/Italy.
Feedback, comments and reviews appreciated!
That part is quite interesting for the mailinglist but should not be part of the commit message, or am I wrong? In that situation such information should be appended after the "---". git-am or similar tools should automatically ignore that parts, but the receiver can still read that comment.
That "---" part was actually meant for the mail and not for the svn commit messages. It will not be stripped from commit messages by git-svn - so it remains in the git master branch. I have removed it manually from my rebase branch - please tell me if that wasn't what you wanted and I will re-add it.
I noticed the "The patch also includes a bug fix...". What exactly do you mean here? I would guess that it is only this part:
/* we only care if the other candidate is even* considered as candidate. */if (tmp_neigh_node2->next_bond_candidate == NULL)continue;
But nice to see that the testing resulted in an even more compact patch which is better readable. :)
Best regards, Sven