Re: [B.A.T.M.A.N.] [PATCH v5 3/4] batman-adv: B.A.T.M.A.N. V - implement GW selection logic

On Mon, Jun 13, 2016 at 01:12:52PM +0200, Sven Eckelmann wrote:

On Sunday 12 June 2016 12:14:25 Antonio Quartulli wrote:

...

--- a/net/batman-adv/gateway_client.c +++ b/net/batman-adv/gateway_client.c @@ -215,6 +215,10 @@ void batadv_gw_election(struct batadv_priv *bat_priv) if (!batadv_atomic_dec_not_zero(&bat_priv->gw.reselect) && curr_gw) goto out;

•   /* if gw.reselect is set to 1 it means that a previous call to
  

•    * gw.is_eligible() said that we have a new best GW, therefore it can
  

•    * now be picked from the list and selected
  

•    */
    next_gw = bat_priv->algo_ops->gw.get_best_gw_node(bat_priv);
  

I would guess that this should be either in patch 2/4 on in an extra patch. At least it is about nothing which is touched otherwise in this patch

Good catch :) Thanks !

I am moving the comment to patch 2/4.

Cheers,