Re: [B.A.T.M.A.N.] [PATCHv2 maint] batman-adv: fix kernel crash due to missing NULL checks

On Thursday, June 18, 2015 21:31:21 Antonio Quartulli wrote:

WARN returns the value of the expression passed as first argument, therefore you can directly pass "!vlan" and use the whole macro invocation as if condition.

I am aware of this 'feature' but I don't find it readable enough. In the Linux kernel I found several code sections using the proposed style too which made me favor it. Do you insist on changing that ?

Note: if you are going to merge this patch before Sven's one you need to also include bug.h.

Ok.

Cheers, Marek