Re: [B.A.T.M.A.N.] [PATCH 09/21] batman-adv: slight optimization of addr compare

On Mon, 2013-12-23 at 09:46 +0100, Antonio Quartulli wrote:

On 23/12/13 06:10, Ding Tianhong wrote:

[...]

...

--- a/net/batman-adv/originator.c +++ b/net/batman-adv/originator.c @@ -41,7 +41,7 @@ int batadv_compare_orig(const struct hlist_node *node, const void *data2) const void *data1 = container_of(node, struct batadv_orig_node, hash_entry);

• return (memcmp(data1, data2, ETH_ALEN) == 0 ? 1 : 0);

• return ether_addr_equal_unaligned(data1, data2) ? 1 : 0;

ether_addr_equal_unaligned() returns a bool value which is implicitly converted to 1 or 0: there is no need for the ternary if anymore.

Should these use batadv_compare_eth?