1 Nov
2011
1 Nov
'11
9:14 a.m.
On Mon, Oct 31, 2011 at 01:10:04AM +0100, Simon Wunderlich wrote:
This patch is not checkpatch.pl --strict clean
On Sun, Oct 30, 2011 at 09:56:00AM +0100, Antonio Quartulli wrote:
- if (unlikely(!pskb_may_pull(skb, ETH_HLEN + arp_hdr_len(skb->dev) + 8 + 12)))
goto out;use ETH_ALEN * 2 + 4 * 2 instead to show where theses numbers come from.
Actually this is a mistake, because I have recently seen that arp_hdr_len() already includes those supplementary bytes.
- bat_dbg(DBG_ARP, bat_priv, "ARP message of type %d recognised "
"[%pM-%pI4 %pM-%pI4]\n", type, ARP_HW_SRC(skb),&ARP_IP_SRC(skb), ARP_HW_DST(skb), &ARP_IP_DST(skb));Would you mind printing the type as string? something like REQUEST or REPLY instead of 1 and 2 ...
Oky
Thanks,
--
Antonio Quartulli
..each of us alone is worth nothing..
Ernesto "Che" Guevara