Hi,
quick summary of the discussion we had:
- Is the check "If the received neighbor is not (yet) a router, drop the OGMv2" still necessary? If yes why?
that appeared to be a simple misunderstanding of our documentation. The phrase was updated to:
If the OGMv2 was received through a neighbor that is not (yet) a router, drop the OGMv2.
If the neighbor is not known the link throughput also is not known which is a requirement for the protocol to function.
Suggestion: Change "If the OGMv2 sequence number is not newer or equal compared to the last received OGMV2 (from any neighbor for this originator) and if the throughput is not better, drop the OGMv2" to: "[...] (from the currently selected router for this originator) [...]"
(-> is another sequence number check here redundant? see "Age check above"? maybe some merging+reordering here?)
Yes, you are right - this seems redundant. The second 'age' check has been removed from the documentation.
- What does "is adopted"/"are applied" mean in section 3.2.2 and section 4? Maybe clarify when the internal stats are updated and when the OGMv2?
Each of the mentioned sections clearly states the intend:
* 3.2.2: If the initial checks above have passed, the internal stats are updated .. * 4: When an OGMv2 is to be re-broadcasted some of the message fields must be changed others must be left unchanged. All fields not mentioned in the following section remain untouched:
- Suggestion:
- Move "forward penalties are applied" to section 4 and change it to "forward penalties are applied to the OGMv2"
Forward penalties are applied on reception but only to routing tables used for forwarding.
- Change "Path Throughput is adopted if its lower than the link throughput to the neighbor, otherwise the link throuput is adopted" to: "If the link throughput to the neighbor this OGMv2 was received from is lower than the Path Throughput of the OGMv2 then set the Path Throughput of the OGMv2 to this link throughput."
Good suggestion! We changed it to:
If the link throughput to the neighbor this OGMv2 was forwarded by is lower than the path throughput of the OGMv2, then this lower link throughput is adopted.
- Remove "The Path throughput for the considered outoging interface is adopted" from section 4.
Forward penalties are applied on a per-outgoing interface basis. This can not be done in a global manner.
Thanks again for the thorough review!
Cheers, Marek