1 Aug
2010
1 Aug
'10
3:28 p.m.
On Saturday 24 July 2010 00:14:29 Sven Eckelmann wrote:
batman-adv tries to resend broadcasts on all interfaces up to three times. For each round and each interface it must provide a skb which gets consumed by the sending function.
It is unnecessary to copy the data of each broadcast because the actual data is either not shared or already copied by add_bcast_packet_to_list. So it is enough to just copy the skb control data
I think the reason to call skb_copy() is the following dev_queue_xmit() call which will consume the given skb. If we consider a case of having 3 interfaces all 3 cloned skbs point to the same data while going out via different interfaces ? I wonder whether that can work ?!
Cheers, Marek