On Freitag, 11. Mai 2018 18:23:07 CEST Marek Lindner wrote:
A translation table TVLV changset sent with an OGM consists of a number of headers (one per VLAN) plus the changeset itself (addition and/or deletion of entries).
The per-VLAN headers are used by OGM recipients for consistency checks. Said consistency check might determine that a full translation table request is needed to restore consistency. If the TT sender adds per-VLAN headers of empty VLANs into the OGM, recipients are led to believe to have reached an inconsistent state and thus request a full table update. The full table does not contain empty VLANs (due to missing entries) the cycle restarts when the next OGM is issued.
Consequently, when the translation table TVLV headers are composed, empty VLANs are to be excluded.
Fixes: 21a57f6e7a3b ("batman-adv: make the TT CRC logic VLAN specific")
Signed-off-by: Marek Lindner mareklindner@neomailbox.ch
v3:
- rebased on top of maint
v2:
- moved changes into batadv_tt_prepare_tvlv_local_data()
- updated 'fixes' commit id
Added as e4687b4be274 [1]
Thanks, Sven
[1] https://git.open-mesh.org/batman-adv.git/commit/e4687b4be274da6180fc15b32741...