14 Jul
2009
14 Jul
'09
2:48 p.m.
On Tuesday 14 July 2009 21:20:04 Andrew Lunn wrote:
What are peoples opinion about this? Should i spend a little time cleaning up all the files? Some code needs refactoring a little, to reducing the nesting, creating more helper functions, but mostly its white space changes. However such changes can cause pain when trying to merge in other work people who diff's are against before the cleanup. Does anybody have any major patches?
I have a major patch myself which I did not upload yet. It aims to improve the routing over multiple interfaces and thus touches quite some files. I'd rather test this stuff a bit longer before I screw up everyones routing. ;-)
So, in my opinion there is not need to hesitate. Cleanup is a good idea.
Regards, Marek