Re: [B.A.T.M.A.N.] [PATCH v4] batman-adv: Snoop DHCPACKs for DAT

On Fri, May 18, 2018 at 11:46:56PM +0200, Sven Eckelmann wrote:

Please correct me but it doesn't look like these things have anything to do with the batman-adv packet format. And userspace should also not use the bootp_pkt/batadv_dhcp_packet definition from batman-adv.

Good point. I could move those to distributed-arp-table.c to avoid userspace from using it.

And what about the basically duplicated bootp_pkt definition in net/ipv4/ ipconfig.c?

Would it make sense to first add it to distributed-arp-table.c and then later I'd make a second patch directly for netdev@ to unify those?

Alternatively, if I'd get a partial ACK for the DHCP snooping approach in general here, I could do it the other way round, of course.

Regards, Linus