Re: [B.A.T.M.A.N.] [PATCH] batman-adv: don't initialise batman_iv private members in hard-interface.c

On Tuesday, April 02, 2013 18:22:50 Antonio Quartulli wrote:

On Tue, Apr 02, 2013 at 12:16:53PM +0200, Antonio Quartulli wrote:

...

From: Antonio Quartulli antonio@open-mesh.com

hard-interface.c has to do not contain any routing algorithm specific code.

Allocate the hard-interface with kzalloc() and remove any useless and algorithm specific member initialisation

Signed-off-by: Antonio Quartulli antonio@open-mesh.com

For whoever is concerned about this missing initialisations, I have to say that those are done in the routing specific API function upon hard-interface activation. Meaning that the seqno and the ogm_buff are initialised somewhere else before being used.

However, using kzalloc, ensure that all the members are initialised to 0 after allocation.

Applied in revision 1cc6cbc.

Thanks, Marek