Re: [B.A.T.M.A.N.] [PATCH] batman-adv: fix memory leak in batadv_softif_create_vlan()

On Thu, Aug 08, 2013 at 12:55:22PM +0800, Marek Lindner wrote:

On Thursday, August 08, 2013 07:07:28 Antonio Quartulli wrote:

...

--- a/soft-interface.c +++ b/soft-interface.c @@ -466,8 +466,10 @@ int batadv_softif_create_vlan(struct batadv_priv *bat_priv, unsigned short vid) atomic_set(&vlan->ap_isolation, 0);

    err = batadv_sysfs_add_vlan(bat_priv->soft_iface, vlan);

•   if (err)
  

•   if (err) {
  

•           kfree(vlan);
            return err;
  

•   }
  

You raise a valid point here but what about the local entry that is added right above ? Does it require cleanup as well ?

Good point! Thanks!

I think I will move the tt_local_add right below this if loop. v2 is coming.

Cheers,