On Wednesday, May 29, 2013 15:58:24 Antonio Quartulli wrote:
From: Antonio Quartulli antonio@open-mesh.com
the icmp and the icmp_rr packets share the same initial fields since they use the same code to be processed and forwarded.
Extract the common fields and put them into a separate struct so that future ICMP packets can be easily added without bloating the packet definition.
However, keep the seqno field outside of the newly created common header because future ICMP types may require a bigger sequence number space.
This change breaks compatibility due to fields reordering in the ICMP headers.
Signed-off-by: Antonio Quartulli antonio@open-mesh.com
v2:
- added changes to packet.h
packet.h | 38 ++++++++++++++++++++++++++++---------- ping.c | 24 ++++++++++++++---------- tcpdump.c | 27 +++++++++++++++++---------- traceroute.c | 31 +++++++++++++++++++------------ 4 files changed, 78 insertions(+), 42 deletions(-)
Applied in revision 9ffe18f.
Thanks, Marek