Re: [B.A.T.M.A.N.] [PATCH] Re: batman-adv: Correct rcu refcounting for gw_node

On Wednesday 02 February 2011 22:42:46 Sven Eckelmann wrote:

...

gw_election():

• can the if-block before gw_deselect() be ommited, we had a nullpointer

  check for curr_gw just a couple of lines before during the rcu-lock.

I thought that this if block should be moved to gw_select. And your gw_select still has the bug that the bat_priv->curr_gw isn't set to NULL when new_gw_node is NULL.

Yes, but we discussed this without Linus.

@Linus: This section will be changed - I'm working on this.

Regards, Marek