Re: [B.A.T.M.A.N.] [PATCH] batman-adv: do not silently ignore wrong condition

30 Mar 2013


      On Saturday, March 30, 2013 22:49:27 Antonio Quartulli wrote:
...
@@ -669,7 +669,7 @@ batadv_iv_ogm_orig_update(struct batadv_priv *bat_priv,
                if (batadv_compare_eth(neigh_addr, ethhdr->h_source) &&
                    tmp_neigh_node->if_incoming == if_incoming &&
                    atomic_inc_not_zero(&tmp_neigh_node->refcount)) {

                  if (neigh_node)




                  if (WARN(neigh_node, "too many matching



neigh_nodes") batadv_neigh_node_free_ref(neigh_node); neigh_node =
tmp_neigh_node;
                        continue;
I wasn't aware one could throw the warning right in the if-statement but for 
the sake of readability, please don't do that.
Cheers,
Marek

    