On Monday 01 December 2014 19:01:37 Philipp Psurek wrote:
I’d like to inform you that I implement the patch posted with this mail 18 h ago. It is a mix of the patch Martin gave me earlier and your 1st patch from “Calculate extra tail size based on queued fragments”. There was no crash, but this means nothing. Now I see, there are many, many patches which solves the bug with different approaches. Please tell me exactly which one I should test because I don't speak any C.
The mixed patch is a good start and doesn't really have to be changed for your test of this specific problem. It misses parts but at least the important change is included. The "final" patches which may need to be tested are (and these should be merged into batman-adv maint):
https://lists.open-mesh.org/pipermail/b.a.t.m.a.n/2014-December/012613.html (this is already in your patch)
https://lists.open-mesh.org/pipermail/b.a.t.m.a.n/2014-December/012620.html (this is not really your problem but I doubt that this is related to any problem you see - but just keep it in mind)
Optional and not relevant for your problem (these should be merged _together_ into batman-adv master):
https://lists.open-mesh.org/pipermail/b.a.t.m.a.n/2014-December/012614.html https://lists.open-mesh.org/pipermail/b.a.t.m.a.n/2014-December/012615.html (these are partially included in your patch - unfortunately your patch misses the part from 012614. And 012615 requires 012614 to work correctly. So just cross your fingers that no one exploits this).
So if you want to have a clean test setup then please include the two non- optional patches (012613, 012620). It is also ok to just include 012613 because this one is most likely related to your problem.
The problem in 012620 should only happen when the difference between batman- adv MTU and device MTU is far too big. A difference of around 1400 bytes. Or if the device MTU is smaller than 1400 then the batman-adv MTU has to be around twice as big as the device MTU. This doesn't seem to be the case here according to your description.
Kind regards, Sven