The "no space is necessary after a cast" sizeof exclusion doesn't work properly.
The test reports a false positive for code like:
BUILD_BUG_ON(sizeof(struct batadv_bla_claim_dst) != 6);
Make it work, simplify the exclusions, and add some comments.
Signed-off-by: Joe Perches joe@perches.com Reported-by: Marek Lindner mareklindner@neomailbox.ch --- scripts/checkpatch.pl | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index d124359..2898e49 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2552,9 +2552,16 @@ sub process { } }
- if ($line =~ /^+.*(\w+\s*)?(\s*$Type\s*)[ \t]+(?!$Assignment|$Arithmetic|[,;:?({}[<>]|&&||||\$)/ && - (!defined($1) || $1 !~ /sizeof\s*/)) { - if (CHK("SPACING", +# check for space after cast like "(int) foo" or "(struct foo) bar" +# avoid checking a few false positives: +# "sizeof(<type>)" or "__alignof__(<type>)" +# function pointer declarations like "(*foo)(int) = bar;" +# structure definitions like "(struct foo) { 0 };" +# multiline macros that define functions +# known attributes or the __attribute__ keyword + if ($line =~ /^+(.*)(\s*$Type\s*)([ \t]++)((?![={]|\$|$Attribute|__attribute__))/ && + (!defined($1) || $1 !~ /\b(?:sizeof|__alignof__)\s*$/)) { + if (CHK("SPACING", "No space is necessary after a cast\n" . $herecurr) && $fix) { $fixed[$fixlinenr] =~