26 Nov
2012
26 Nov
'12
9:34 a.m.
On Mon, Nov 26, 2012 at 09:15:44AM +0800, Marek Lindner wrote:
On Monday, November 26, 2012 08:41:17 Antonio Quartulli wrote:
struct batadv_priv_nc {
struct delayed_work work;
- struct dentry *debug_dir;
- u8 min_tq;
If I am not mistaken min_tq is never modified. Why do we need to store it in a bat_priv field? And being a constant is it worth a define? In this way it an be easily found and tuned like the other constant params.
It can be modified via debugfs:
file = debugfs_create_u8("min_tq", S_IRUGO | S_IWUSR, nc_dir,&bat_priv->nc.min_tq);
Oh, ok! I hadn't seen the "W" in the mode. Thanks.
Cheers,
--
Antonio Quartulli
..each of us alone is worth nothing..
Ernesto "Che" Guevara