On Tuesday 29 March 2016 19:59:57 Adrian Reyer wrote: [...]
It would also be interesting if it should be a simple flag or some if exporting the num_bcasts via $something would be sufficient. Or if the num_bcasts should be split into num_bcasts_otherif and num_bcasts_sameif and then exported.
It is two different things, the num_bcasts in my understanding is about how many times the originator sends out its packets to assume everyone has received it. The flag we talk about is about if anyone receiving that packet on an interface has to send it out on that very interface at all, e.g. it is about everyone reachable via that interface sees the same neighbours (e.g. switch) or a different group (e.g. wlan adhoc)
Thats why I said that it would have to be split into *sameif and *otherif.
And btw. it is not about the originator. It is handled in batadv_send_outstanding_bcast_packet at the same place where you want to have the no_rebroadcast check. no_rebroadcast in the patch we are talking [1,2] about is currently just ignoring the num_bcasts of a hard-interface for some situations (when forw_packet->skb->dev == hard_iface->net_dev).
Kind regards, Sven
[1] https://patchwork.open-mesh.org/patch/3434/ [2] https://patchwork.open-mesh.org/patch/4384/