It is hard to understand why the refcnt is increased when it isn't done near the actual place the new reference is used. So using kref_get right before the place which requires the reference and in the same function helps to avoid accidental problems causedy incorrect reference counting.
Signed-off-by: Sven Eckelmann sven@narfation.org --- v2: - split patch based on type
net/batman-adv/originator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/batman-adv/originator.c b/net/batman-adv/originator.c index 3940b5d..d778eb1 100644 --- a/net/batman-adv/originator.c +++ b/net/batman-adv/originator.c @@ -127,9 +127,9 @@ batadv_orig_node_vlan_new(struct batadv_orig_node *orig_node, goto out;
kref_init(&vlan->refcount); - kref_get(&vlan->refcount); vlan->vid = vid;
+ kref_get(&vlan->refcount); hlist_add_head_rcu(&vlan->list, &orig_node->vlan_list);
out: