Re: [B.A.T.M.A.N.] [PATCH 01/11] batman-adv: don't rely on positions in struct for hashing

From: Antonio Quartulli ordex@autistici.org Date: Tue, 13 Nov 2012 10:15:29 +0100

@@ -37,18 +37,26 @@ static void batadv_bla_periodic_work(struct work_struct *work); static void batadv_bla_send_announce(struct batadv_priv *bat_priv, struct batadv_backbone_gw *backbone_gw);

+static inline void hash_bytes(uint32_t *hash, void *data, uint32_t size) +{

• const unsigned char *key = data;
• int i;
• for (i = 0; i < size; i++) {

• *hash += key[i];
  

• *hash += (*hash << 10);
  

• *hash ^= (*hash >> 6);
  

• }

+}

Remove the inline tag.

Return the uint32_t resulting hash value rather than passing it by reference.