Re: [B.A.T.M.A.N.] [RFC 1/2] batman-adv: invoke post_func only if the attribute has been changed

On Wed, Mar 06, 2013 at 06:53:02PM +0800, Marek Lindner wrote:

On Wednesday, March 06, 2013 18:33:00 Antonio Quartulli wrote:

...

@@ -169,7 +169,7 @@ __batadv_store_bool_attr(char *buff, size_t count,

    ret = batadv_store_bool_attr(buff, count, net_dev, attr->name,
                                 attr_store);

•   if (post_func && ret)
  

•   if (post_func && ret > 0)
            post_func(net_dev);
  
    return ret;
  

If I remember correctly the shell or some other system between the kernel and userspace did not like to have 0 returned. It resulted in some funny "try to set this value over and over" reaction. You might want to test that.

Oh ok. I will look for that. I think in that case we can simply change the value returned by __batadv_store_bool_attr() and leave batadv_store_bool_attr() returning 0 so that from outside we can still understand if the value has been changed or not.

Thanks a lot! Cheers,