17 Feb
2016
17 Feb
'16
8:39 a.m.
On Wednesday 17 February 2016 00:51:10 Dominik Heidler wrote:
The alfred client sets the mac to zero by default so this shouldn't break existing behaviour.
This also may not to be true. Some users of alfred may not set the source in alfred_data and thus they may end up with random bytes when reusing a buffer, allocating a buffer without memset or using an uninitialized buffer on stack.
It is bad practice to send uninitialized bytes around but I just wanted to point out that potential problem.
Your patch also doesn't explain why this feature may be required.
Btw. you can grep for "data_source" to find the code related to the sync/forwarded rules of alfred.
Kind regards, Sven