Hi,

overall I think this is a good idea. Please see below:

On Sunday, June 23, 2019 3:07:03 PM CEST Sven Eckelmann wrote:

Hi,

I've asked a quite while back for some ideas regarding the support for hard interface settings in batctl [1]. The current consensus seems to be that a more iw-like interface is prefered.

vlan settings

The requirement to have a VLAN master device on top of the batadv mesh interface is artificially limiting the capabilities of batctl. Not all master devices in linux which register a VLAN are from type "vlan" and are only registering a single VLAN.

For example VLAN aware bridges can create multiple VLANs. These require that the VLAN is identified using the VID and not the vlan device.

It is now possible to specify the vlan using:

$ batctl vlan bat0.8 ap_isolation enable $ batctl meshif bat0 vid 8 ap_isolation enable

hardif settings

The infrastructure for the new vlan/vid prefix of commands can now be used to introduce another prefix: "hardif".

B.A.T.M.A.N. V introduced two additional settings which are hard (slave) interface specific. These can can finally be implemented in batctl. This will allow to change/read these settings when sysfs support is not enabled in the kernel.

$ batctl hardif eth0 throughput_override 15mbit $ batctl hardif eth0 elp_interval

Changes

v2

• replaced (while still being compatible) -m option with "meshif"/"dev"

prefix * added alternative "slave" for "hardif" prefix

I'd drop those alternative names "slave" and "dev". If we want to change the naming, we have to do it everywhere. If we don't change the naming, then I would say we shouldn't even advertise an alternative naming to not confuse users and keep everything consistent. And if don't advertise, there is no good reason to parse it and bloat the code.

That's my take, at least. :)

In general, I really like the tree like structure in favor of an unituitive option parsing.

Cheers, Simon