Dan Carpenter wrote: [...]
It looks a little bit like checked with clang's static analyzer. This analyzer has problems to track constraints at all. This means that it doesn't catch the update_routes constraint "orig_node->router != neigh_node".
But I am also not good at tracking that kind of constraints and reported this or a similar "bug" in batmand a while ago.
So it is not a real bug, but maybe not easy to read.
Yeah. I see what you mean...
Good. And thanks for the bug report. It is always good that someone looks over the code :)
Best regards, Sven