Re: [B.A.T.M.A.N.] [RFC v4 00/19] batman-adv: netlink restructuring, part 2

Sat, Jan 19, 2019 at 04:56:07PM CET, sven@narfation.org wrote:

Hi,

Jiri Pirko called the batman-adv configuration interface a while back "a huge mistake" [1] and suggested genl as alternative. The first reimplementation [2] (based on the team/devlink design) was rejected. This second implementation is now using a nl80211-like design. The objects which can now be modified/queried are:

• mesh/soft-interface (BATADV_CMD_GET_MESH/BATADV_CMD_SET_MESH)
• slave/hard-interface (BATADV_CMD_GET_HARDIF/BATADV_CMD_SET_HARDIF)
• vlan (BATADV_CMD_GET_VLAN/BATADV_CMD_SET_VLAN)

Such a set messages automatically triggers a *_SET_* "reply" via the config multicast group. The same behavior was also added to the sysfs interface.

In general aside of couple of nits I described, this iteration of the patchset looks very nice to me. Thanks!