Re: [B.A.T.M.A.N.] [PATCH 4/4] batctl: add netlink dump function for multicast flags table

On Dienstag, 27. Februar 2018 09:10:59 CET Linus Lüssing wrote:

•   /* only parse own multicast flags */
  

•   info_header = netlink_get_info(ifindex, BATADV_CMD_GET_MCAST_FLAGS, NULL);
  

•   free(info_header);
  

•   if (mcast_flags < 0 || mcast_flags_priv < 0)
  

•           return -EINVAL;
  

Let us assume for now that the kernel doesn't yet support the netlink mcast_flags and the rest of the mcast netlink code. It will now try to get the mcast_flags from the kernel and fail. Thsi function is now returning -EINVAL and handle_debug_table will now compare the return code to -EOPNOTSUPP and notice that a different error happened and stops the processing. Would be nice when it would not really stop and instead try to get the data from debugfs (via the old code which is still in batctl).

Kind regards, Sven