On Tue, Oct 16, 2012 at 02:09:23AM +0200, Sven Eckelmann wrote:
On Sunday 14 October 2012 22:03:01 Antonio Quartulli wrote:
Different versions of the batman-adv module may use the same compatibility version, but this is not understandable at runtime (the only way is to parse the kernel log and fetch the batman-adv advertisement message on loading). The user may want to know whether two nodes using different versions can communicate or not. For this purpose the module has to export this value through debugfs.
Reported-by: Moritz Warning moritzwarning@web.de Signed-off-by: Antonio Quartulli ordex@autistici.org
[...]
+/**
- batadv_compat_seq_print_text - print the compatibility version
- @seq: not used
- @offset: not used
- */
+int batadv_compat_seq_print_text(struct seq_file *seq, void *offset) +{
- seq_printf(seq, "%d\n", BATADV_COMPAT_VERSION);
- return 0;
+}
seq is not used? Marek also segfaulted after reading this.
You, know..when you really don't know what to write in the kernel doc...!! I'm going to change it :-)
Thanks Sven,
p.s. please reboot Marek