Re: [B.A.T.M.A.N.] [PATCH] batman-adv: move neigh_node->if_incoming->if_status check in find_router()

On gio, mag 05, 2011 at 02:20:10 +0200, Marek Lindner wrote:

On Thursday 05 May 2011 10:21:42 Antonio Quartulli wrote:

...

return_router:

•   if (router && router->if_incoming->if_status != IF_ACTIVE)
  

•           router = NULL;
  

•   rcu_read_unlock();
    return router;
  

You are breaking the reference counting of 'router' here. While looking at your patch I found another refcount imbalance. Check the patch I just posted (Fix refcount imbalance in find_router).

I see :) And thanks for reviewing.

Regards,