On Tuesday, 7 May 2019 15:30:46 HKT Sven Eckelmann wrote:
On Tuesday, 7 May 2019 09:28:21 CEST Linus Lüssing wrote:
This mark prevents a multicast packet being flooded through the whole mesh. The advantage of marking certain multicast packets via e.g. ebtables instead of dropping is then the following:
This allows an administrator to let specific multicast packets pass as long as they are forwarded to a limited number of nodes only and are therefore creating no burdon to unrelated nodes.
Signed-off-by: Linus Lüssing linus.luessing@c0d3.blue
I still don't see why this has to be implemented in batman-adv and not as an external filter (tc-ebpf or something like that).
As I understand the use-case (Linus correct me if I am wrong): The mark is supposed to drop packets that couldn't be $optimized by one of the various batman-adv payload traffic optimizations. From outside of batman-adv it would be difficult to tell if a broadcast / multicast packet was optimized (think: served via DAT cache, sent as unicast, etc) or not.
@Linus: How about making the intention clearer by choosing a better name (for example: nobroadcast mark) and introducing proper documentation when and how to use this flag ?
Cheers, Marek