Re: [B.A.T.M.A.N.] [PATCHv3] batman-adv: fix old master freeing operation

On Friday, March 22, 2013 16:49:55 Antonio Quartulli wrote:

When a new hard_iface has a master already, ndo_del_slave has to be used in order to let the old master perform its cleaning up routine correctly. Unsetting the master iface only can lead to a inconsistent state in the master driver.

Introduced by 5e57e3bff429cd403f0e30af69cf87a2cd55598f ("batman-adv: free an hard-interface before adding it").

Reported-by: Marek Lindner lindner_marek@yahoo.de Signed-off-by: Simon Wunderlich siwu@hrz.tu-chemnitz.de Signed-off-by: Antonio Quartulli ordex@autistici.org

---

v2:

• patch restyled
• added compat code for <2.6.39 (Thanks to Simon)

v3:

• commit message rewording
• change EINVAL to EBUSY to better describe the error

compat.h | 3 +++ hard-interface.c | 29 +++++++++++++++++++++++++++-- 2 files changed, 30 insertions(+), 2 deletions(-)

Applied in revision 9e96c4d.

Thanks, Marek